This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add in_flight handle to active sessions #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a daemon plugin executes for longer than a poll interval it will continue running in the background. This can cause buffering of resources in the case of a misbehaving call.
We've seen this when `lnetctl export` hangs due to large numbers of peers.
We can add a in_flight handle to active sessions.
If we hit the deadline while a plugin is in a poll, we can drop the pending future and poll the plugin again. This will ensure we don't buffer misbehaving resources when a deadline elapses.
Fixes #1998.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
johnsonw
previously approved these changes
Jun 23, 2020
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Jun 23, 2020
johnsonw
approved these changes
Jun 23, 2020
jgrund
added a commit
that referenced
this pull request
Jun 23, 2020
* Add in_flight handle to active sessions
If a daemon plugin executes for longer than a poll interval it will continue running in the background. This can cause buffering of resources in the case of a misbehaving call.
We've seen this when `lnetctl export` hangs due to large numbers of peers.
We can add a in_flight handle to active sessions.
If we hit the deadline while a plugin is in a poll, we can drop the pending future and poll the plugin again. This will ensure we don't buffer misbehaving resources when a deadline elapses.
Fixes #1998.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
* fmt fixups
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a daemon plugin executes for longer than a poll interval it will continue running in the background. This can cause buffering of resources in the case of a misbehaving call.
We've seen this when
lnetctl exporthangs due to large numbers of peers.We can add an
in_flighthandle to active sessions.If we hit the deadline while a plugin is in a poll, we can drop the pending future and poll the plugin again. This will ensure we don't buffer misbehaving resources when a deadline elapses.
Fixes #1998.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is