This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Error on unknown FS #2350
Merged
Error on unknown FS #2350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pankov <work@michaelpankov.com>
ip1981
previously approved these changes
Oct 28, 2020
Signed-off-by: Michael Pankov <work@michaelpankov.com>
ip1981
approved these changes
Oct 28, 2020
|
Can you post a screenshot of the output with the change in place? |
johnsonw
approved these changes
Oct 28, 2020
|
You're hitting the same error I was seeing yesterday: Try restarting |
jgrund
reviewed
Oct 28, 2020
| @@ -254,6 +258,9 @@ impl QueryRoot { | |||
| context: &Context, | |||
| fs_name: Option<String>, | |||
| ) -> juniper::FieldResult<Vec<TargetResource>> { | |||
| if let Some(ref fs_name) = fs_name { | |||
| let _ = fs_id_by_name(&context.pg_pool, &fs_name).await?; | |||
There was a problem hiding this comment.
nit: is the let _ = necessary when you already are handling the result?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Pankov work@michaelpankov.com
This change is