This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrund
reviewed
Nov 6, 2020
jgrund
reviewed
Nov 6, 2020
jgrund
reviewed
Nov 6, 2020
jgrund
reviewed
Nov 6, 2020
76cc6c7
to
1970510
Compare
e9cae11
to
7866f7f
Compare
5c138cf
to
a844239
Compare
jgrund
suggested changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has conflicts on latest master.
First pass at filesync restore Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
No need to have a scan job run. Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
56e0fee
to
d34088b
Compare
jgrund
reviewed
Dec 18, 2020
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
suggested changes
Dec 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a number of usages of unwrap
that will crash the process if they are hit.
In addition, an argument of task::create was updated without updating any client calls.
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
jgrund
reviewed
Dec 19, 2020
I've reviewed this thoroughly, it should be good to land once the requested changes are made. |
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
jgrund
approved these changes
Dec 20, 2020
utopiabound
pushed a commit
that referenced
this pull request
Apr 5, 2021
* EX-1979 filesync restore First pass at filesync restore Signed-off-by: Ben Evans <beevans@whamcloud.com> * Enable lipe scan for restore Signed-off-by: Ben Evans <beevans@whamcloud.com> * Fix issue with 'Push' vs. 'push' Signed-off-by: Ben Evans <beevans@whamcloud.com> * clippy fixes Signed-off-by: Ben Evans <beevans@whamcloud.com> * Fileysnc data mover rewrite Signed-off-by: Ben Evans <beevans@whamcloud.com> * Fixed formatting Signed-off-by: Ben Evans <beevans@whamcloud.com> * Added code for adding tasks and tasklists No need to have a scan job run. Signed-off-by: Ben Evans <beevans@whamcloud.com> * added code to create a task independent of Lipe. Signed-off-by: Ben Evans <beevans@whamcloud.com> * juniper query improvements Signed-off-by: Ben Evans <beevans@whamcloud.com> * rebase Signed-off-by: Ben Evans <beevans@whamcloud.com> * Bump Signed-off-by: Ben Evans <beevans@whamcloud.com> * Functioning with push and pull, if the files are on lustre Signed-off-by: Ben Evans <beevans@whamcloud.com> * fix warnings, cargo cruft Signed-off-by: Ben Evans <beevans@whamcloud.com> * Fixes from review Signed-off-by: Ben Evans <beevans@whamcloud.com> * Get rid of two more unwraps Signed-off-by: Ben Evans <beevans@whamcloud.com> * Code review changes Signed-off-by: Ben Evans <beevans@whamcloud.com> * Use expression that is already pattern matched Signed-off-by: Joe Grund <jgrund@whamcloud.io> Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at filesync restore
Signed-off-by: Ben Evans beevans@whamcloud.com
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)