Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

EX-1979 filesync restore #2367

Merged
merged 17 commits into from
Dec 20, 2020
Merged

EX-1979 filesync restore #2367

merged 17 commits into from
Dec 20, 2020

Conversation

beevans
Copy link
Contributor

@beevans beevans commented Nov 6, 2020 •
edited by jgrund
Loading

First pass at filesync restore

Signed-off-by: Ben Evans beevans@whamcloud.com

This change is Reviewable

jgrund
jgrund reviewed Nov 6, 2020
View reviewed changes
iml-agent/Cargo.toml Outdated Show resolved Hide resolved
@beevans beevans requested a review from jgrund December 10, 2020 16:18
jgrund
jgrund suggested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has conflicts on latest master.

@beevans
EX-1979 filesync restore
08826d4 
First pass at filesync restore

Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Enable lipe scan for restore
9e2b299 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Fix issue with 'Push' vs. 'push'
8f1c774 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
clippy fixes
f2b97dc 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Fileysnc data mover rewrite
7398c13 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Fixed formatting
12893a1 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Added code for adding tasks and tasklists
80973a9 
No need to have a scan job run.

Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
added code to create a task independent of Lipe.
1580789 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
juniper query improvements
254f851 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
rebase
d34088b 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Bump
1ae786c 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Functioning with push and pull, if the files are on lustre
6e9de7d 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans beevans requested a review from jgrund December 18, 2020 22:56
@beevans
fix warnings, cargo cruft
b8a5ef5 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
jgrund suggested changes Dec 19, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of usages of unwrap that will crash the process if they are hit.

In addition, an argument of task::create was updated without updating any client calls.

iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/task.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-api/src/graphql/mod.rs Outdated Show resolved Hide resolved
iml-agent/src/action_plugins/stratagem/action_filesync.rs Outdated Show resolved Hide resolved
iml-agent/src/action_plugins/stratagem/action_filesync.rs Outdated Show resolved Hide resolved
iml-manager-cli/src/stratagem.rs Outdated Show resolved Hide resolved
iml-manager-cli/src/stratagem.rs Outdated Show resolved Hide resolved
@beevans
Fixes from review
cc92fb5 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@beevans
Get rid of two more unwraps
1807a22 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@jgrund jgrund self-requested a review December 19, 2020 21:24
@jgrund
Copy link
Member

jgrund commented Dec 19, 2020

I've reviewed this thoroughly, it should be good to land once the requested changes are made.

@beevans
Code review changes
5529f97 
Signed-off-by: Ben Evans <beevans@whamcloud.com>
@jgrund jgrund self-requested a review December 20, 2020 13:52
@jgrund
Use expression that is already pattern matched
a899658 
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
@jgrund jgrund merged commit 0cd46b3 into master Dec 20, 2020
@jgrund jgrund deleted the EX-1979-restore branch December 20, 2020 17:06
utopiabound pushed a commit that referenced this pull request Apr 5, 2021
@beevans @jgrund
EX-1979 filesync restore (#2367)
8ac047c 
* EX-1979 filesync restore

First pass at filesync restore

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Enable lipe scan for restore

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Fix issue with 'Push' vs. 'push'

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* clippy fixes

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Fileysnc data mover rewrite

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Fixed formatting

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Added code for adding tasks and tasklists
No need to have a scan job run.

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* added code to create a task independent of Lipe.

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* juniper query improvements

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* rebase

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Bump

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Functioning with push and pull, if the files are on lustre

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* fix warnings, cargo cruft

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Fixes from review

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Get rid of two more unwraps

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Code review changes

Signed-off-by: Ben Evans <beevans@whamcloud.com>

* Use expression that is already pattern matched

Signed-off-by: Joe Grund <jgrund@whamcloud.io>

Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund jgrund approved these changes

@utopiabound utopiabound Awaiting requested review from utopiabound

Assignees

@beevans beevans

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@beevans @jgrund