Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpins django-bootstrap to allow other versions #13

Merged
merged 1 commit into from Apr 28, 2016

Conversation

jefftriplett
Copy link
Contributor

I worked on an Django 1.9 app which needs a newer version of django-bootstrap3 (7.0.1) which is not released yet. This project also requires django-base-theme which uninstalls my pinned version because this setup is pinned to a specific version.

馃悢 and 馃嵆 if you will.

I'm happy to discuss the change with you or the project can work off of my pinned version as an interim solution until django-bootstrap3 catches up :)

@chadwhitman
Copy link
Member

chadwhitman commented Apr 28, 2016

Hey Jeff - yeah this should be fine. Merged it in. Thanks!

@chadwhitman chadwhitman merged commit b98252b into wharton:master Apr 28, 2016
@chadwhitman
Copy link
Member

Also, on a side note, and for anyone else taking note of this commit...I think I'll eventually remove those installs in the setup.py (i.e., font awesome & bootstrap). I think I would rather add those stylesheets to my SASS build anyway so, in the end, it all compiles into one css file and thus I only need one http request to get what I need. If you go the setup.py file route, you typically pipe them into your template via tags like {% fontawesome_stylesheet %} or {% bootstrap_styles %}, which works, but it creates two more requests and I want the slimmest performance I can get. I already did this (i.e., remove installs from setup.py) for Django Flexbox Theme (https://github.com/wharton/django-flexbox-theme)....

@FlipperPA
Copy link
Member

Makes sense to me, good work by both of you - I had monkey patched the bootstrap3 dependency in the WRDS fork I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants