Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct media type #62

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Set correct media type #62

merged 1 commit into from
Sep 30, 2022

Conversation

willtho89
Copy link
Collaborator

according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types application/vnd.openxmlformats-officedocument.spreadsheetml.sheet should be used. Closes #60

according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types `application/vnd.openxmlformats-officedocument.spreadsheetml.sheet` should be used. Closes #60
@willtho89
Copy link
Collaborator Author

@FlipperPA is there a reason application/xlsx was used?

@FlipperPA
Copy link
Member

@willtho89 Not in particular, just from years of habit dating back to my PHP days. 👍 This sounds right to me, let's just make sure we still have it properly open the default spreadsheet app with the new media_type.

@FlipperPA FlipperPA merged commit cda74db into main Sep 30, 2022
@FlipperPA
Copy link
Member

Thank you! This has been published to PyPI at 2.2.0:

https://github.com/wharton/drf-excel/releases/tag/2.2.0

https://pypi.org/project/drf-excel/2.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Common media_type
2 participants