Conforming to current jasmine api. Passing needed test values #42
Conversation
| @@ -1,5 +1,5 @@ | |||
| var Jasmine = require('jasmine'); | |||
| var SpecReporter = require('jasmine-spec-reporter'); | |||
| var { SpecReporter } = require('jasmine-spec-reporter'); | |||
There was a problem hiding this comment.
jasmine-spec-reporter has a couple objects. Dunno if it always did
| @@ -5,7 +5,7 @@ | |||
| "An API to help facilitate the use of the Yahoo! Fantasy Sports API in NodeJS projects.", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "node -r @std/esm jasmine-runner.js", | |||
| "test": "node -r esm jasmine-runner.js", | |||
There was a problem hiding this comment.
Scoped package @std/esm is not currently in the package.json, but plain esm is. Could alternatively switch the package.json to @std/esm.
tests/gameResource.spec.js
Outdated
| @@ -67,13 +67,13 @@ describe("resource : gameResource", function() { | |||
| }); | |||
|
|
|||
| beforeEach(function() { | |||
| spyOn(yf, "api").andCallThrough(); | |||
| spyOn(yf, "api").and.callThrough(); | |||
There was a problem hiding this comment.
Seems that jasmine changed their API in version 2. Version 3 is specified in the package.json, so I think we need this syntax.
| }); | ||
|
|
||
| // leagues | ||
| describe(": leagues", function() { | ||
| it("should build a proper url to retrieve league data for a single league using a numeric game key", function() { | ||
| game.leagues(328, "328.l.34014", null); | ||
| game.leagues(328, "328.l.34014", () => {}); |
There was a problem hiding this comment.
Just need to provide some callback, even though we aren't testing the value called-back-with.
tests/leagueResource.spec.js
Outdated
| }); | ||
|
|
||
| // meta | ||
| it ("should build a proper url to retrieve metadata via a league key", function() { | ||
| nock('https://fantasysports.yahooapis.com') | ||
| .get("/fantasy/v2/league/328.l.34014/metadata?format=json") | ||
| .reply(200, {}); | ||
| .reply(200, require("./nock-data/leagueMeta").meta); |
There was a problem hiding this comment.
Need to return some data, because the object mapping classes expect there to be at least a fantasy_content field.
tests/leagueResource.spec.js
Outdated
| .get("/fantasy/v2/league/328.l.34014/players?format=json") | ||
| .reply(200, {}); | ||
| // // players | ||
| // it ("should build a proper url to retrieve players via a league key", function() { |
There was a problem hiding this comment.
This is commented out in the source, so there is nothing to test yet.
|
I'll take a look at this tonight... funny thing is I actually made a bunch of changes locally but didn't merge them in yet as I still had a few things breaking... thanks! |
| nock("https://fantasysports.yahooapis.com") | ||
| .get("/fantasy/v2/league/328.l.34014/players?format=json") | ||
| .reply(200, {}); | ||
| // // players |
There was a problem hiding this comment.
This was commented out in the source, so there is nothing to test
There was a problem hiding this comment.
ya the tests are a never ending process :P
|
Yeah, those changes you had were some of it. Still need to nock out some endpoints and provide a callback |
| @@ -51,9 +51,9 @@ describe("resource: leagueResource", function() { | |||
| it("should build a proper url to retrieve metadata via a league key", function() { | |||
| nock("https://fantasysports.yahooapis.com") | |||
| .get("/fantasy/v2/league/328.l.34014/metadata?format=json") | |||
| .reply(200, {}); | |||
| .reply(200, require("./nock-data/leagueMeta").meta); | |||
There was a problem hiding this comment.
Need to return some data, because the object mapping classes expect there to be at least a fantasy_content field.
I started to implement #41 and wanted to see if the existing tests still passed, but they weren't running.
Wanted to get them working for before adding the feature. Just a few things off, comments inline.