Fix: Selected Position for Roster/TeamRoster #69
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "selected_position" not being properly extracted from the response payloads for
team.roster
androster.players
.It seems that at some point, Yahoo changed their format of the payload without updating the documentation.
I have replaced the
nock-testdata
with the latest real data for the same test team and date.It is hard to see in this CL, but if you look for "selected_position", it was changed from:
To this:
Though I have updated the test data, there are no tests which verify the actual extraction of the data from the payloads. All of the tests are testing the existence of the API and the structure of the URLs (which have not changed).