Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #195. Make -webkit-background-clip an alias of background-clip. #196

Merged
merged 1 commit into from Jun 17, 2022

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Jun 14, 2022

This fixes the spec tests to be aligned with the reality as described in the issue #195
There is no need for special treatment.


Preview | Diff

@karlcow karlcow changed the title Issue #195. Make -webkit-background-clip an alias of background-clip. Fix #195. Make -webkit-background-clip an alias of background-clip. Jun 14, 2022
@karlcow karlcow requested a review from miketaylr June 14, 2022 22:48
@karlcow
Copy link
Member Author

karlcow commented Jun 15, 2022

OK this is green. Let's do a rebase. :)

compatibility.bs Outdated Show resolved Hide resolved
compatibility.bs Outdated Show resolved Hide resolved
compatibility.bs Outdated Show resolved Hide resolved
@karlcow
Copy link
Member Author

karlcow commented Jun 17, 2022

Changes done. Thanks @miketaylr for the review and suggestions.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Karl!

@miketaylr miketaylr merged commit dbc61f1 into main Jun 17, 2022
@miketaylr miketaylr deleted the 195/1 branch June 17, 2022 19:44
@gsnedders
Copy link
Contributor

Do we not need tests for this, per the WHATWG working mode?

@karlcow
Copy link
Member Author

karlcow commented Jun 19, 2022

@gsnedders Probably a good idea. We should double check if the tests exist for both prefixed and unprefixed versions.

@karlcow
Copy link
Member Author

karlcow commented Jun 20, 2022

@gsnedders I opened this issue. Feel free to tell me on the issue if it's what you had in mind.
web-platform-tests/wpt#34493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants