Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Firefox 'nan' vs. 'NaN' inconsistency. #38

Closed
wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Member

No description provided.

@robertkowalski
Copy link
Member

Thank you!

I merged 2fde8b5 yesterday which removes another difference from the list.

I would like to have it consistent so we should decide on removing it or adding a link to the issue etc.

@terinjokes @domenic @frewsxcv do you have any opinions what might work best?

@domenic
Copy link
Member

domenic commented Jan 28, 2016

I like removing in general, but maybe some kind of appendix of "recently fixed bugs" or similar would be interesting. Alternately we could just rely on the Git history.

@terinjokes
Copy link
Collaborator

My preference is to remove it with good commit messages, and relying on the file's Git history.

@robertkowalski
Copy link
Member

@frewsxcv is it OK for you to delete the entry and add a good commit message (maybe also mentioning in which FF version it was fixed and the link https://bugzilla.mozilla.org/show_bug.cgi?id=1239506) or is that completely impractical for you?

As per https://bugzilla.mozilla.org/show_bug.cgi?id=1239506, Firefox
will start printing 'NaN' instead of 'nan' when formatting `NaN` values
starting in Firefox 47.
@frewsxcv
Copy link
Member Author

@robertkowalski Let me know how that looks

@frewsxcv frewsxcv changed the title Mention Firefox inconsistency has been fixed in NOTES.md. Remove mention of Firefox 'nan' vs. 'NaN' inconsistency. Jan 29, 2016
@robertkowalski
Copy link
Member

LGTM thank you! 👍

robertkowalski pushed a commit that referenced this pull request Jan 29, 2016
As per https://bugzilla.mozilla.org/show_bug.cgi?id=1239506, Firefox
will start printing 'NaN' instead of 'nan' when formatting `NaN` values
starting in Firefox 47.

PR: #38
PR-URL: #38
Reviewed-By: Robert Kowalski <rok@kowalski.gd>
@robertkowalski
Copy link
Member

merged as d9e224a

@frewsxcv frewsxcv deleted the patch-1 branch January 29, 2016 21:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants