Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DOMSettableTokenList into DOMTokenList #119

Closed
annevk opened this issue Nov 25, 2015 · 2 comments
Closed

Merge DOMSettableTokenList into DOMTokenList #119

annevk opened this issue Nov 25, 2015 · 2 comments

Comments

@annevk
Copy link
Member

annevk commented Nov 25, 2015

Per discussion on IRC with @domenic and @zcorpan only HTML uses these classes. It seems like we could simplify things a bit by merging them into a single class and use [PutForward] everywhere.

The problem I could see is that libraries depend on changing the prototype of these classes in ways that are incompatible with such a simplification. What do folks think?

@zcorpan
Copy link
Member

zcorpan commented Nov 25, 2015

If changing prototypes is an issue we could do the same thing as how HTMLDocument is specced in HTML, such that window.DOMSettableTokenList === window.DOMTokenList.

@zcorpan
Copy link
Member

zcorpan commented Nov 26, 2015

In httparchive i only see http://www.gstatic.com/caja/5678/es53-taming-frame.opt.js?debug=1 containing "DOMSettableTokenList.prototype" but it was actually "TameDOMSettableTokenList.prototype".

Looking at all instances of "DOMSettableTokenList" is just a handful of copies of http://kpn.blueconic.net/frontend/static/javascript/blueconic/blueconic.min.js which does

var myGlobalVarBlacklist=["window","top","location","external","chrome", ... ,"DOMSettableTokenList"

So probably we don't need to keep window.DOMSettableTokenList around.

zcorpan added a commit that referenced this issue Nov 26, 2015
Move DOMSettableTokenList#value to DOMTokenList and remove the
DOMSettableTokenList interface.
zcorpan added a commit that referenced this issue Jan 1, 2016
Move DOMSettableTokenList#value to DOMTokenList and remove the
DOMSettableTokenList interface.
zcorpan added a commit that referenced this issue Jan 28, 2016
Move DOMSettableTokenList#value to DOMTokenList and remove the
DOMSettableTokenList interface.
@annevk annevk closed this as completed in 07e9fc0 Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants