-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe throw NotSupportedError for createEvent('touchevent') #1071
base: main
Are you sure you want to change the base?
Conversation
See w3c/touch-events#64 The term "expose legacy touch event APIs" was introduced in w3c/touch-events#111
c984b83
to
996ac3c
Compare
The TouchEvent interface is still exposed.
0d0cb07
to
103b06e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
See whatwg/dom#1071 Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Via BrowserStack, I checked the tests in Safari 15.4 on an iPhone 13, Chrome and Firefox on Android 12 on a Google Pixel 6. There were no surprises other than a test bug which I've submitted a fix for at web-platform-tests/wpt#33811 I haven't checked Deno or Node, other than the results for the relevant tests are |
When at least one of w3c/touch-events#115 and w3c/touch-events#114 are merged (and the term flows through to be visible to the bikeshed build server), the build error should go away. |
See whatwg/dom#1071 Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
CI is green now |
Does this close #952? What about https://bugzilla.mozilla.org/show_bug.cgi?id=1693172? |
Yes.
Hmm. I thought Firefox exposed But running the test locally on macOS desktop Firefox it's not exposed. Maybe it's a difference between Linux and macOS? In any case, we should indeed make a decision whether What's specified now in the touch events spec + this PR matches Chromium, but seemingly not Safari or Firefox. |
…nt'), a=testonly Automatic update from web-platform-tests DOM: Test document.createEvent('touchevent') See whatwg/dom#1071 Co-authored-by: Anne van Kesteren <annevk@annevk.nl> -- wpt-commits: 75e0de2aa153aea2e31860cd6ec4628b7b673011 wpt-pr: 33605
…nt'), a=testonly Automatic update from web-platform-tests DOM: Test document.createEvent('touchevent') See whatwg/dom#1071 Co-authored-by: Anne van Kesteren <annevk@annevk.nl> -- wpt-commits: 75e0de2aa153aea2e31860cd6ec4628b7b673011 wpt-pr: 33605
See w3c/touch-events#64
Depends on w3c/touch-events#111
Closes #952
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff