Save the is="" value an element was created with #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of fixing whatwg/html#1298 and whatwg/html#1360.
domenic
added a commit
to whatwg/html
that referenced
this pull request
Jun 1, 2016
This uses the new "is value" concept introduced to DOM in whatwg/dom#262, which more correctly implements the intention that changing the is attribute after element creation does not impact the processing model, and thus fixes #1298. This allows us to then fix #1360: custom element callback reactions for customized built-in elements were not correctly looking up their definition.
domenic
added a commit
to whatwg/html
that referenced
this pull request
Jun 6, 2016
This uses the new "is value" concept introduced to DOM in whatwg/dom#262, which more correctly implements the intention that changing the is attribute after element creation does not impact the processing model, and thus fixes #1298. This allows us to then fix #1360: custom element callback reactions for customized built-in elements were not correctly looking up their definition.
domenic
added
the
topic: custom elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fixing whatwg/html#1298 and whatwg/html#1360.