New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enqueueing custom element reactions is ineffective for customized built-in elements #1360
Comments
It seems like this is just a simple typo and it should be "with local name equal to element's local name"? |
That doesn't work for customized built-in elements; you might have |
Ah of course; thank you. I guess everything is leaning toward storing an extra piece of state on the element. I'll try to make that change soon... |
Part of fixing whatwg/html#1298 and whatwg/html#1360.
Part of fixing whatwg/html#1298 and whatwg/html#1360.
This uses the new "is value" concept introduced to DOM in whatwg/dom#262, which more correctly implements the intention that changing the is attribute after element creation does not impact the processing model, and thus fixes #1298. This allows us to then fix #1360: custom element callback reactions for customized built-in elements were not correctly looking up their definition.
Part of fixing whatwg/html#1298 and whatwg/html#1360.
This uses the new "is value" concept introduced to DOM in whatwg/dom#262, which more correctly implements the intention that changing the is attribute after element creation does not impact the processing model, and thus fixes #1298. This allows us to then fix #1360: custom element callback reactions for customized built-in elements were not correctly looking up their definition.
Enqueue a callback reaction step 4 says:
This will not find a definition for customized built-in elements because their local names (for example, "button") are not valid custom element names, hence no such definition exists.
Given the idea that changing an element's "is" attribute does not affect its behavior, this points to the need for extra state associated with the element which remembers the original value of "is" for lookups like this.
The text was updated successfully, but these errors were encountered: