New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Editorial: add missing 'if' #512
Conversation
Thanks! Would you like to add your name to the Acknowledgments section? The commit message you want here is probably something like
but I can correct that when landing. We should probably centrally define the commit message rules for WHATWG since we tend to apply https://github.com/whatwg/meta/blob/master/TEAM.md#handling-pull-requests as well, which isn't very clear. |
Correct @annevk and I agree fully! As you would recommend perhaps for another Issue (that I can take care of myself)? That said the commit is updated. By the way...where is the "Acknowledgements" section? |
Acknowledgments is a section in the standard itself. The same file you're already patching. A commit message rules issue would probably be best over at https://github.com/whatwg/meta/issues/new and then we can figure out where to host the rules and get all the standards to link them. Thanks! |
@annevk Updated as per your request. #TodayILearned ... if the needle is far enough down in the LOC haystack not even VIM search finds the word. I can't make this stuff up. Ever think of "partializing" the spec? (whatever that would mean here) Just a thought. Is there anything else we need for this one? Or can I go have a celebratory 🍷 later?:-) |
You can go ahead and do that, cheers! 😊 |
(To answer your question, I don't really like the idea of splitting up this file. It's rather convenient for a standard to be in a single one. There must be some way to configure Vim so it can deal with it better.) |
Haha, I missed you sneaked in an emoji. Nice. |
@annevk i'll blame it on beginner's luck. 🙄 ;-) See you around the issues! ✋ |
📝 Fixes #508 Grammatical error with missing 'if'
Preview | Diff