Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Otherwise, localName is associated attribute’s ..." #508

Closed
domenic opened this issue Sep 10, 2017 · 1 comment
Closed

"Otherwise, localName is associated attribute’s ..." #508

domenic opened this issue Sep 10, 2017 · 1 comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@domenic
Copy link
Member

domenic commented Sep 10, 2017

https://dom.spec.whatwg.org/commit-snapshots/c9544325095195c3afdf6284c29b26e84ce572aa/#interface-domtokenlist

Otherwise, localName is associated attribute’s local name,

Missing word "if" before localName

@domenic domenic added the good first issue Ideal for someone new to a WHATWG standard or software project label Sep 10, 2017
snuggs added a commit to snuggs/dom that referenced this issue Sep 14, 2017
📝 Fix whatwg#508 Grammatical error with missing 'if'
@snuggs
Copy link
Member

snuggs commented Sep 14, 2017

#512

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of an email and the rest of the text as the body. The blank
line separating the summary from the body is critical (unless you omit
the body entirely)
; tools like rebase can get confused if you run the
two together.

Focused on the "unless you omit the body entirely" part. (Ockham's Razor)

Super amped at what I believe is my first contribution to whatwg/dom! 🎉 Long overdue.

Was a little confused about whether or not "first line in commit message" really was just the summary. Hence the duplication.

Please let me know what corrections I need to make. 💪

snuggs added a commit to snuggs/dom that referenced this issue Sep 14, 2017
annevk pushed a commit that referenced this issue Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

2 participants