-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: create a concept for event's target #621
Conversation
@miketaylr fc16564 created some rebase issues for your work on event dispatch so I figured I'd start helping a bit. Would you be willing to review this? Would you be willing to add |
Sounds good! edit: filed #625 for the srcElement/returnValue bit. |
Cool, did you review this change? |
I've got time carved out this afternoon, stand by. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM with one small typo.
Should we update the following from 2.1?:
The event ’s target attribute value returns the object to which the event was dispatched ( obj above).
The other mention of target below that seems easier to understand in the context of the code example as-is:
Each time the event ’s target attribute value will be the span element .
dom.bs
Outdated
<p>The <dfn attribute for=Event><code>target</code></dfn> attribute's getter must return the | ||
<a>context object</a>'s <a for=Event>target</a>. | ||
|
||
<p>The <dfn attribute for=Event><code>currentTarget</code></dfn> attribute must return the values it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/values/value/
I decided to leave the mention in the introduction since it seems clearer there as it is now. We might even want to say property getter or some such there. |
Fixes #570.
Preview | Diff