Editorial: use IDL to simplify create an element #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per whatwg/html#4525 a custom element constructor is required to be an HTMLElement. Also, rather than assume another specification will make foreign namespace objects implement HTMLElement, let's instead assert that does not happen as we cannot test it.
|
How does this work given the following? customElements.define("x-y", class extends HTMLElement {
constructor() {
return {}; // not a HTMLElement
}
}); |
domenic
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
I see, IDL's "constructing" checks this after the changes in whatwg/html#4525. So, let's not merge this until that happens, but LGTM in general.
dom.bs
Outdated
| <li><p>Assert: <var>result</var>'s <a for=Element>custom element state</a> and | ||
| <a for=Element>custom element definition</a> are initialized. | ||
|
|
||
| <li><p>Assert: <var>result</var>'s <a for=Element>namespace</a> is the <a>HTML namespace</a>. |
There was a problem hiding this comment.
I think it's still worth keeping a note why this assert is true: it's because IDL enforced that result is a HTMLElement instance, and at this point in time all HTMLElement instances have the HTML namespace.
There was a problem hiding this comment.
That makes it sound like it might change to me, but I've added a similar note.
domenic
added
topic: custom elements
annevk
added a commit
to whatwg/html
that referenced
this pull request
Apr 15, 2019
And allow for simplification of "create an element" by moving a step into IDL. Tests: web-platform-tests/wpt#16328. Corresponding DOM changes: whatwg/dom#751. Fixes #4520.
annevk
removed
the
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per whatwg/html#4525 a custom element constructor is required to be an HTMLElement.
Also, rather than assume another specification will make foreign namespace objects implement HTMLElement, let's instead assert that does not happen as we cannot test it.