Use "NotSupportedError" when trying to attachShadow() twice #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in #760. This makes the various cases less distinguishable, which is desirable. With this change, all three cases behave the same between: - A custom element with disabled-shadow - A custom element with a shadow tree - A built-in element on the blocklist
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 15, 2019
This was referenced May 15, 2019
tkent-google
approved these changes
May 15, 2019
|
I think I can say that Mozilla is fine with this change. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
…), a=testonly Automatic update from web-platform-tests Update error type test for attachShadow() Follows whatwg/dom#761. -- wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff wpt-pr: 16853
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
…), a=testonly Automatic update from web-platform-tests Update error type test for attachShadow() Follows whatwg/dom#761. -- wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff wpt-pr: 16853
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…), a=testonly Automatic update from web-platform-tests Update error type test for attachShadow() Follows whatwg/dom#761. -- wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff wpt-pr: 16853 UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…), a=testonly Automatic update from web-platform-tests Update error type test for attachShadow() Follows whatwg/dom#761. -- wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff wpt-pr: 16853 UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…), a=testonly Automatic update from web-platform-tests Update error type test for attachShadow() Follows whatwg/dom#761. -- wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff wpt-pr: 16853 UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
zdobersek
pushed a commit
to Igalia/webkit
that referenced
this pull request
Oct 5, 2019
https://bugs.webkit.org/show_bug.cgi?id=197948 Reviewed by Wenson Hsieh. LayoutTests/imported/w3c: Rebaselined the tests. * web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt: * web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt: Source/WebCore: Match the latest spec. See whatwg/dom#761 * dom/Element.cpp: (WebCore::Element::attachShadow): Throw NotSupportedError when there is already a shadow tree. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #760. This makes the various cases less distinguishable,
which is desirable. With this change, all three cases behave the same
between:
Tests: web-platform-tests/wpt#16853
Preview | Diff