Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document gb18030 decoder end-of-queue oddity #254

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Document gb18030 decoder end-of-queue oddity #254

merged 1 commit into from
Feb 27, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 26, 2021 •
edited by pr-preview bot
Loading

Closes #253.

Preview | Diff

@annevk annevk mentioned this pull request Feb 26, 2021
Closed
ricea
ricea approved these changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@annevk annevk merged commit 26f6e56 into main Feb 27, 2021
@annevk annevk deleted the annevk/gb18030-oddity branch February 27, 2021 06:45
@hsivonen
Copy link
Member

hsivonen commented Mar 1, 2021

LGTM as a gb18030-specific documentation step, but we still haven't solved the issue opposite to what's being documented here: #171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricea ricea ricea approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End-of-queue during decoding of GB18030 should not mask ASCII characters.
3 participants
@annevk @hsivonen @ricea