Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "filesystem" URL scheme #846

Closed
annevk opened this issue Dec 6, 2018 · 7 comments
Closed

Remove "filesystem" URL scheme #846

annevk opened this issue Dec 6, 2018 · 7 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@annevk
Copy link
Member

annevk commented Dec 6, 2018

As far as I know there's only one implementation. Also need to add historical tests.

@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project needs tests Moving the issue forward requires someone to write tests labels Dec 6, 2018
@M-ZubairAhmed
Copy link
Contributor

hi @annevk can you please tell me more about this issue, i would like to give this a try. Thank you

@annevk
Copy link
Member Author

annevk commented Feb 17, 2019

This would require removing the three occurences of "filesystem" in the standard, along with corresponding text for the third instance.

(You can ignore "needs tests". I'm not sure how I imagined to test for this. I don't think that's actually possible.)

@annevk annevk removed the needs tests Moving the issue forward requires someone to write tests label Feb 17, 2019
@M-ZubairAhmed
Copy link
Contributor

thank you , will surely look into it this weekend. Also please go easy on me, i have very rarely collaborated in large public project 🐌

@domenic
Copy link
Member

domenic commented Feb 21, 2019

I think this could be tested, by creating a fetchable file using the Chrome-only filesystem APIs and then trying to fetch() it.

@annevk
Copy link
Member Author

annevk commented Feb 22, 2019

As a Chrome-only test? That doesn't seem like a good fit for wpt.

@domenic
Copy link
Member

domenic commented Feb 22, 2019

Well, we could make the test also pass if those Chrome-only APIs weren't present, I guess. Like, we'd have a historical test saying those Chrome-only APIs weren't present, then a second historical test saying "if they are present, filesystem URLs should not work".

@annevk
Copy link
Member Author

annevk commented Feb 22, 2019

Filed web-platform-tests/wpt#15525 on that idea.

@annevk annevk closed this as completed in 265974f Feb 22, 2019
annevk added a commit to whatwg/html that referenced this issue Feb 22, 2019
This is not defined to have an effect. I.e., the ideas in https://www.w3.org/Bugs/Public/show_bug.cgi?id=25734 never materialized.

See also #3862 and whatwg/fetch#846.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Development

No branches or pull requests

3 participants