Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue-846 : remove URL filesystem scheme #873

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Fixed Issue-846 : remove URL filesystem scheme #873

merged 4 commits into from
Feb 22, 2019

Conversation

M-ZubairAhmed
Copy link
Contributor

@M-ZubairAhmed M-ZubairAhmed commented Feb 21, 2019 •
edited by pr-preview bot
Loading

Preview | Diff

annevk
annevk reviewed Feb 22, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great. I've got a couple nits and note that you should feel free to add yourself to the Acknowledgments section.

fetch.bs Outdated Show resolved Hide resolved
fetch.bs Show resolved Hide resolved
@M-ZubairAhmed
Copy link
Contributor Author

I updated with the suggestions

@annevk annevk merged commit 265974f into whatwg:master Feb 22, 2019
@annevk
Copy link
Member

annevk commented Feb 22, 2019

Thank you, great work!

@M-ZubairAhmed M-ZubairAhmed deleted the issue846 branch February 22, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-ZubairAhmed @annevk