Use referrer policy from policy container #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on whatwg/html#6677 |
annevk
reviewed
May 17, 2021
annevk
approved these changes
May 17, 2021
There was a problem hiding this comment.
I guess we'll wait for @domfarolino to double check (as he's also signed up for the other PRs), but this looks good from my perspective. Thanks!
Done, although I am not sure about the formulation (in principle, this can be used to override policy container's referrer policy, which in turn can be used to override the environment settings objects' policy container's referrer policy). |
|
I've been traveling the last few days; I'll check this out within the next two days. |
3 tasks
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
May 31, 2021
This change moves referrer policy from Document/WorkerGlobalScope into policy container. This allows us to simplify several steps (initializing for new empty documents, populating from the response headers, inheriting for local scheme documents), since they are handled centrally via the policy container mechanisms. Companion PRs: * whatwg/fetch#1233 * w3c/ServiceWorker#1593 (removes referrer policy from service workers as that comes for free with policy container) * w3c/webappsec-referrer-policy#152 The change is mostly a refactoring and should have no significant behavioral changes, apart from simplifying the referrer policy inheritance mechanism. The most visible behavioral change of this is that referrer policy of a srcdoc iframe will be now copied from the parent document at creation time instead of referencing the parent document referrer policy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion change to whatwg/html#6677, which moves referrer policy into the policy container.
As a consequence of this change, the referrer policy used for the request is a snapshot of the relevant referrer policy when the request is being created, and won't change during the lifetime of the request, addressing a variant of #832 for referrer policy.
Preview | Diff