Editorial: align with URL's cannot-be-base-URL removal #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These URLs now have a path whose value is a string rather than a list. See whatwg/url#655 for context.
annevk
added a commit
to whatwg/url
that referenced
this pull request
Oct 19, 2021
Tests: web-platform-tests/wpt#31305. Fetch PR: whatwg/fetch#1337. HTML PR: whatwg/html#7240. URLPattern PR: whatwg/urlpattern#143. Follow-up: #659. Fixes #634.
domenic
approved these changes
Oct 19, 2021
fetch.bs
Outdated
| <a for=response>header list</a> consist of a single <a for=/>header</a> whose | ||
| <a for=header>name</a> is `<code>Content-Type</code>` and <a for=header>value</a> is | ||
| `<code>text/html;charset=utf-8</code>`, and <a for=response>body</a> is the empty byte sequence. | ||
| <p>If <var>request</var>'s <a for=request>current URL</a>'s <a for=url>path</a> is |
There was a problem hiding this comment.
Maybe the string "blank" for extra clarity? It's redundant but might help a bit.
fetch.bs
Outdated
| is "<code>about</code>", and <a for=url>path</a> contains a single string | ||
| "<code>client</code>" | ||
| <li><p><var>parsedReferrer</var>'s <a for=url>scheme</a> is "<code>about</code>" and | ||
| <a for=url>path</a> is "<code>client</code>" |
|
I'm fine with trying that for a bit. Normally I end up removing those type restatements, but these URLs are not too frequent so maybe it can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These URLs now have a path whose value is a string rather than a list.
See whatwg/url#655 for context.
Preview | Diff