-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: align with URL's cannot-be-base-URL removal #143
Conversation
These URLs now have a path whose value is a string rather than a list. See whatwg/url#655 for context.
Hey @annevk! Could you join the WICG to appease the IPR bots? |
Tests: web-platform-tests/wpt#31305. Fetch PR: whatwg/fetch#1337. HTML PR: whatwg/html#7240. URLPattern PR: whatwg/urlpattern#143. Follow-up: #659. Fixes #634.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM. Sorry for the delay looking at it.
There appears to be an IPR bot issue, though. Yoav suggests you need to join WICG?
I don't want to join WICG, but I'm happy to release this under CC0 or equivalent. |
Looks like this is also failing the build on |
I suspect that's because the Build ran when that term had not yet landed in the URL Standard? Or did you run it again recently? |
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Ok, build successful. Just need you to join WICG now to satisfy IPR bot. |
wanderview marked as non substantive for IPR from ash-nazg. |
These URLs now have a path whose value is a string rather than a list.
See whatwg/url#655 for context.
Preview | Diff