Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: align with URL's cannot-be-base-URL removal #143

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Editorial: align with URL's cannot-be-base-URL removal #143

merged 2 commits into from
Nov 22, 2021

Conversation

annevk
Copy link
Member

@annevk annevk commented Oct 19, 2021

These URLs now have a path whose value is a string rather than a list.

See whatwg/url#655 for context.


Preview | Diff

These URLs now have a path whose value is a string rather than a list.

See whatwg/url#655 for context.
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@yoavweiss
Copy link
Contributor

Hey @annevk! Could you join the WICG to appease the IPR bots?

annevk added a commit to whatwg/url that referenced this pull request Oct 19, 2021
Copy link
Member

@wanderview wanderview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM. Sorry for the delay looking at it.

There appears to be an IPR bot issue, though. Yoav suggests you need to join WICG?

spec.bs Outdated Show resolved Hide resolved
@annevk
Copy link
Member Author

annevk commented Nov 18, 2021

I don't want to join WICG, but I'm happy to release this under CC0 or equivalent.

@wanderview
Copy link
Member

Looks like this is also failing the build on url path serializing definition.

@annevk
Copy link
Member Author

annevk commented Nov 18, 2021

I suspect that's because the Build ran when that term had not yet landed in the URL Standard? Or did you run it again recently?

Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@wanderview
Copy link
Member

Ok, build successful. Just need you to join WICG now to satisfy IPR bot.

@w3cbot
Copy link

w3cbot commented Nov 22, 2021

wanderview marked as non substantive for IPR from ash-nazg.

@wanderview wanderview merged commit dbb9521 into whatwg:main Nov 22, 2021
@annevk annevk deleted the annevk/opaque-paths branch November 23, 2021 07:47
crowlKats added a commit to crowlKats/rust-urlpattern that referenced this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants