Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block subresource requests whose URLs include credentials. #465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jan 24, 2017

  1. Block subresource requests whose URLs include credentials.

    Hard-coding credentials into subresource requests (e.g.
    `https://user:pass@host/`) is problematic from a security perspective,
    as it's allowed folks to brute-force credentials in the past, enables
    session fixation attacks for sites using basic auth, and can allow
    attackers access to well-known, poorly-coded devices (such as users'
    routers). Moreover, the ability to hard-code credentials leads to
    inadvertant leakage via XSS on the one hand, and poor development
    practice on the other. Sifting through HTTPArchive, for example, yields
    a number of credentials for test servers and other internal
    architecture.
    
    Usage of the `http://user:pass@host/` pattern has [declined significantly
    in the last few years][1]; given that low usage, closing this small
    security hole seems quite reasonable.
    
    [1]: https://www.chromestatus.com/metrics/feature/timeline/popularity/532
    [2]: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/lx-U_JR2BF0
    mikewest committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    5faf329 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2017

  1. fixup Subresource.

    mikewest committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    e28f797 View commit details
    Browse the repository at this point in the history