New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block AFP ports (427, 548) #738
Conversation
Also remove some obsolete comments. Fixes #694.
I wonder if there's some formal way to represent all these protocols. This is https://www-archive.mozilla.org/projects/netlib/PortBanning.html lowercased, but that's not necessarily great. (Tracked by #750 now.) |
(Note to self: scan web-platform-tests for this list to ensure it's kept up-to-date if it exists.) |
Tests: web-platform-tests/wpt#11249. |
As discussed in #482 and already fixed in Chrome.
Note: I added a second commit that will block a port that Chrome has been blocking for quite a while. |
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
I've also filed https://bugs.chromium.org/p/chromium/issues/detail?id=872252 about the fact that all of the tests in web-platform-tests/wpt#11249 are failing because the bad port check happens synchronously in the constructor. @annevk, given that all browsers seem to do this, do you think we should change the spec instead? |
I was wrong, Edge passes these tests: https://wpt.fyi/results/websockets/Create-blocked-port.any.html?sha=edb72456b7 |
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
Also remove some obsolete comments.
Fixes #694.
Preview | Diff