New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block AFP ports (427, 548) #738

Merged
merged 2 commits into from May 31, 2018

Conversation

2 participants
@annevk
Member

annevk commented May 25, 2018

Also remove some obsolete comments.

Fixes #694.


Preview | Diff

Block AFP ports (427, 548)
Also remove some obsolete comments.

Fixes #694.
@annevk

This comment has been minimized.

Member

annevk commented May 25, 2018

I wonder if there's some formal way to represent all these protocols. This is https://www-archive.mozilla.org/projects/netlib/PortBanning.html lowercased, but that's not necessarily great. (Tracked by #750 now.)

@annevk

This comment has been minimized.

Member

annevk commented May 25, 2018

(Note to self: scan web-platform-tests for this list to ensure it's kept up-to-date if it exists.)

@annevk annevk requested a review from yutakahirano May 30, 2018

annevk added a commit to web-platform-tests/wpt that referenced this pull request May 30, 2018

@annevk

This comment has been minimized.

Member

annevk commented May 30, 2018

Block another IRC port (6697)
As discussed in #482 and already fixed in Chrome.
@annevk

This comment has been minimized.

Member

annevk commented May 30, 2018

Note: I added a second commit that will block a port that Chrome has been blocking for quite a while.

@annevk annevk merged commit 2e45674 into master May 31, 2018

2 checks passed

Participation annevk participates on behalf of Mozilla Corporation
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@annevk annevk deleted the annevk/block-afp-ports branch May 31, 2018

annevk added a commit to web-platform-tests/wpt that referenced this pull request Jun 5, 2018

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 27, 2018

Bug 1465437 [wpt PR 11249] - Fetch: port blocking change (427, 548), …
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 28, 2018

Bug 1465437 [wpt PR 11249] - Fetch: port blocking change (427, 548), …
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

jdashg pushed a commit to jdashg/gecko-cinn that referenced this pull request Jun 30, 2018

Bug 1465437 [wpt PR 11249] - Fetch: port blocking change (427, 548), …
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

jdashg pushed a commit to jdashg/gecko-cinn that referenced this pull request Jun 30, 2018

Bug 1465437 [wpt PR 11249] - Fetch: port blocking change (427, 548), …
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249
@foolip

This comment has been minimized.

Member

foolip commented Aug 8, 2018

I've also filed https://bugs.chromium.org/p/chromium/issues/detail?id=872252 about the fact that all of the tests in web-platform-tests/wpt#11249 are failing because the bad port check happens synchronously in the constructor. @annevk, given that all browsers seem to do this, do you think we should change the spec instead?

@foolip

This comment has been minimized.

Member

foolip commented Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment