Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block AFP ports (427, 548) #738

Merged
merged 2 commits into from May 31, 2018
Merged

Block AFP ports (427, 548) #738

merged 2 commits into from May 31, 2018

Conversation

@annevk
Copy link
Member

@annevk annevk commented May 25, 2018

Also remove some obsolete comments.

Fixes #694.


Preview | Diff

Also remove some obsolete comments.

Fixes #694.
@annevk
Copy link
Member Author

@annevk annevk commented May 25, 2018

I wonder if there's some formal way to represent all these protocols. This is https://www-archive.mozilla.org/projects/netlib/PortBanning.html lowercased, but that's not necessarily great. (Tracked by #750 now.)

@annevk
Copy link
Member Author

@annevk annevk commented May 25, 2018

(Note to self: scan web-platform-tests for this list to ensure it's kept up-to-date if it exists.)

@annevk annevk requested a review from yutakahirano May 30, 2018
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 30, 2018
@annevk
Copy link
Member Author

@annevk annevk commented May 30, 2018

As discussed in #482 and already fixed in Chrome.
@annevk
Copy link
Member Author

@annevk annevk commented May 30, 2018

Note: I added a second commit that will block a port that Chrome has been blocking for quite a while.

@annevk annevk merged commit 2e45674 into master May 31, 2018
2 checks passed
2 checks passed
@whatbot
Participation annevk participates on behalf of Mozilla Corporation
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@annevk annevk deleted the annevk/block-afp-ports branch May 31, 2018
annevk added a commit to web-platform-tests/wpt that referenced this pull request Jun 5, 2018
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 27, 2018
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 28, 2018
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249
jdashg pushed a commit to jdashg/gecko-cinn that referenced this pull request Jun 30, 2018
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249
jdashg pushed a commit to jdashg/gecko-cinn that referenced this pull request Jun 30, 2018
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249
@foolip
Copy link
Member

@foolip foolip commented Aug 8, 2018

I've also filed https://bugs.chromium.org/p/chromium/issues/detail?id=872252 about the fact that all of the tests in web-platform-tests/wpt#11249 are failing because the bad port check happens synchronously in the constructor. @annevk, given that all browsers seem to do this, do you think we should change the spec instead?

@foolip
Copy link
Member

@foolip foolip commented Aug 8, 2018

gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 3, 2019
…a=testonly

Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697)

See whatwg/fetch#738.
--

wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed
wpt-pr: 11249

UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants