Block AFP ports (427, 548) #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some obsolete comments. Fixes #694.
|
I wonder if there's some formal way to represent all these protocols. This is https://www-archive.mozilla.org/projects/netlib/PortBanning.html lowercased, but that's not necessarily great. (Tracked by #750 now.) |
|
(Note to self: scan web-platform-tests for this list to ensure it's kept up-to-date if it exists.) |
annevk
added
addition/proposal
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
May 30, 2018
|
Tests: web-platform-tests/wpt#11249. |
As discussed in #482 and already fixed in Chrome.
|
Note: I added a second commit that will block a port that Chrome has been blocking for quite a while. |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 5, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 27, 2018
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 28, 2018
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
kdashg
pushed a commit
to kdashg/gecko-cinn
that referenced
this pull request
Jun 30, 2018
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
kdashg
pushed a commit
to kdashg/gecko-cinn
that referenced
this pull request
Jun 30, 2018
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249
|
I've also filed https://bugs.chromium.org/p/chromium/issues/detail?id=872252 about the fact that all of the tests in web-platform-tests/wpt#11249 are failing because the bad port check happens synchronously in the constructor. @annevk, given that all browsers seem to do this, do you think we should change the spec instead? |
|
I was wrong, Edge passes these tests: https://wpt.fyi/results/websockets/Create-blocked-port.any.html?sha=edb72456b7 |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: 8119ee3bcb261511106e18c1fbc9509e33d15918
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…a=testonly Automatic update from web-platform-testsFetch: port blocking change (427, 548, 6697) See whatwg/fetch#738. -- wpt-commits: 2b0cd6155aa269d3ee6e940edb1b2f5c1d5ae1ed wpt-pr: 11249 UltraBlame original commit: d6cc520386d5f01e0acebaa76aa0da8920b3a931
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove some obsolete comments.
Fixes #694.
Preview | Diff