-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: turn CORS-preflight cache into a list #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor bugs, but otherwise LGTM
.travis.yml
Outdated
script: | ||
- curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh && bash ./deploy.sh | ||
- make deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems unrelated to the editorial stuff. Is this mostly a separate change?
fetch.bs
Outdated
and either <var>request</var>'s <a for=request>method</a> is a not a | ||
<a>CORS-safelisted method</a> or <var>request</var>'s | ||
<ul class=brief> | ||
<li><p>There is no <a for=cache>method cache entry match</a> for <var>request</var>'s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove for=cache
.
fetch.bs
Outdated
<dt><a for=cache>url</a> | ||
<dd><var>request</var>'s <a for=request>current url</a> | ||
<dl> | ||
<dt><a for=cache>serialized origin</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this <dl>
, for=cache
should be for="cache entry"
(or remove the for
from each item and add link-for="cache entry"
to the <dl>
.
fetch.bs
Outdated
<dt><a for=cache>method</a> | ||
<dd><p><var>method</var> | ||
|
||
<dt><p><a for=cache>header name</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove <p>
.
bc86651
to
2a7f0a2
Compare
Thanks, I think I got them all. I also dropped the .travis.yml change and will put that in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change.
fetch.bs
Outdated
<var>request</var> and which is not a <a>CORS-safelisted request-header</a>. | ||
<li><p>There is at least one <a for=/>header</a> in <var>request</var>'s | ||
<a for=request>header list</a> for whose <a for=header>name</a> there is no | ||
<a for=cache>header-name cache entry match</a> using <var>request</var> and which is not a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove for=cache
This grounds it a bit more in an Infra data structure. Fixes #735.
25e0768
to
b82c39c
Compare
(I had to rebase.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, spotted one more
fetch.bs
Outdated
<a>CORS-preflight cache</a> for which there is a | ||
<a for=cache>cache match</a> for <var>request</var> and one of | ||
<p>There is a <dfn id=concept-cache-match-header>header-name cache entry match</dfn> for | ||
<var>headerName</var> using <var>request</var> when there is a <a>entry entry</a> in the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a>entry entry</a>
to <a>cache entry</a>
I think
@jakearchibald sorry for the long ping-pong. I addressed all Bikeshed warnings now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! |
This grounds it a bit more in an Infra data structure.
Fixes #735.
Preview | Diff