Editorial: turn CORS-preflight cache into a list #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
requested changes
Aug 15, 2018
.travis.yml
Outdated
| script: | ||
| - curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh && bash ./deploy.sh | ||
| - make deploy |
There was a problem hiding this comment.
This seems unrelated to the editorial stuff. Is this mostly a separate change?
fetch.bs
Outdated
| and either <var>request</var>'s <a for=request>method</a> is a not a | ||
| <a>CORS-safelisted method</a> or <var>request</var>'s | ||
| <ul class=brief> | ||
| <li><p>There is no <a for=cache>method cache entry match</a> for <var>request</var>'s |
fetch.bs
Outdated
| <dt><a for=cache>url</a> | ||
| <dd><var>request</var>'s <a for=request>current url</a> | ||
| <dl> | ||
| <dt><a for=cache>serialized origin</a> |
There was a problem hiding this comment.
In this <dl>, for=cache should be for="cache entry" (or remove the for from each item and add link-for="cache entry" to the <dl>.
fetch.bs
Outdated
| <dt><a for=cache>method</a> | ||
| <dd><p><var>method</var> | ||
|
|
||
| <dt><p><a for=cache>header name</a> |
annevk
force-pushed
the
annevk/cors-preflight-cache-list
branch
from
bc86651
to
2a7f0a2
Compare
|
Thanks, I think I got them all. I also dropped the .travis.yml change and will put that in a separate PR. |
jakearchibald
requested changes
Aug 16, 2018
fetch.bs
Outdated
| <var>request</var> and which is not a <a>CORS-safelisted request-header</a>. | ||
| <li><p>There is at least one <a for=/>header</a> in <var>request</var>'s | ||
| <a for=request>header list</a> for whose <a for=header>name</a> there is no | ||
| <a for=cache>header-name cache entry match</a> using <var>request</var> and which is not a |
This grounds it a bit more in an Infra data structure. Fixes #735.
annevk
force-pushed
the
annevk/cors-preflight-cache-list
branch
from
25e0768
to
b82c39c
Compare
|
(I had to rebase.) |
jakearchibald
requested changes
Aug 16, 2018
fetch.bs
Outdated
| <a>CORS-preflight cache</a> for which there is a | ||
| <a for=cache>cache match</a> for <var>request</var> and one of | ||
| <p>There is a <dfn id=concept-cache-match-header>header-name cache entry match</dfn> for | ||
| <var>headerName</var> using <var>request</var> when there is a <a>entry entry</a> in the user |
There was a problem hiding this comment.
<a>entry entry</a> to <a>cache entry</a> I think
|
@jakearchibald sorry for the long ping-pong. I addressed all Bikeshed warnings now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This grounds it a bit more in an Infra data structure.
Fixes #735.
Preview | Diff