Fixing variable definitions and scoping. Fixes #706. #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
commented
May 30, 2018
fetch.bs
Outdated
| @@ -2857,16 +2857,14 @@ with a <i>CORS flag</i> and <i>recursive flag</i>, run these steps: | |||
| <var>noCorsResponse</var>. | |||
|
|
|||
| <li> | |||
| <p>Set <var>corbSanitizedResponse</var> to a new <a for=/>response</a> whose | |||
| <p>Return a new <a for=/>response</a> whose | |||
There was a problem hiding this comment.
Let me fix the wrapping here
annevk
reviewed
May 30, 2018
fetch.bs
Outdated
|
|
||
| <li><p>Let <var>storedResponse</var> be null. | ||
|
|
||
| <li><p>Let <var>revalidatingFlag</var> be an unset flag. |
There was a problem hiding this comment.
The original phrasing for this is slightly more correct, or at least consistent with what we're trying to aim for these days... (I'm sorry, I wish we had never done flags and started with booleans.)
There was a problem hiding this comment.
I went with the above with consistency with other "let"s, but I'll put it back…
annevk
reviewed
May 30, 2018
| <a for=response>status</a> is <var>noCorsResponse</var>'s <a for=response>status</a>, | ||
| <a for=response>HTTPS state</a> is <var>noCorsResponse</var>'s | ||
| <a for=response>HTTPS state</a>, and <a for=response>CSP list</a> is | ||
| <var>noCorsResponse</var>'s <a for=response>CSP list</a>. |
|
Filed speced/bikeshed#1255 in case there's a way to detect this at build time. |
|
Thanks, I hope that works out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this horrible piece of code (run in the console) to identify variables that weren't correctly defined.
Preview | Diff