Editorial: stop using "promise-calling" #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/webidl#795 for context.
|
cc @Ms2ger |
domenic
requested changes
Sep 13, 2019
There was a problem hiding this comment.
I think this can be much simpler. CreateReadableStream accepts algorithms. You have created an algorithm which promise-calls a function but that function is really just an algorithm.
Instead, you should just pass the algorithms (pull and cancel) to CreateReadableStream semi-directly.
I say "semi-directly" because CreateReadableStream expects the algorithms to return promises. As far as I can tell nothing in the fetch spec needs that. So you need a small wrapper algorithm that returns "a promise resolved with undefined".
But you shouldn't need promise-calling at all, or to go through Web IDL, for this.
|
Thanks! I think it's good now. |
domenic
approved these changes
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/webidl#795 for context.
Preview | Diff