Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty dictionary default value for requestFullscreen #158

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add empty dictionary default value for requestFullscreen #158

merged 1 commit into from
Sep 26, 2019

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 25, 2019 •
edited by pr-preview bot

Closes #157.

Preview | Diff

@foolip foolip mentioned this pull request Sep 25, 2019
Closed
@foolip foolip requested a review from annevk September 25, 2019 21:29
annevk
annevk approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the PR from Kagami might be better, but maybe removing the markup should be a separate editorial change.

@foolip
Copy link
Member Author

foolip commented Sep 26, 2019

I removed that because it seemed like an unintended change by the tooling, but I'll check what effect removing it has and if it does nothing removing it separately.

@foolip foolip merged commit 20ea24b into master Sep 26, 2019
@foolip foolip deleted the foolip/default-value branch September 26, 2019 09:17
@foolip
Copy link
Member Author

foolip commented Sep 26, 2019

Looks like it has no interesting effect:
https://whatpr.org/fullscreen/157.html#dictdef-fullscreenoptions
https://fullscreen.spec.whatwg.org/#dictdef-fullscreenoptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foolip @annevk