Skip to content

Commit

Permalink
Fix review issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@jgraham
jgraham committed May 4, 2021
1 parent be2bbee commit 5be33e8
Showing 1 changed file with 37 additions and 35 deletions.
72 changes: 37 additions & 35 deletions source
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84386,7 +84386,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface

<dl>
<dt><dfn data-x="navigation-params-id">id</dfn></dt>
<dd>A unique opaque string that identifies the navigation</dd>
<dd>A unique string that identifies the navigation</dd>

<dt><dfn data-x="navigation-params-request">request</dfn></dt>
<dd>null or a <span data-x="concept-request">request</span> that started the navigation</dd>
Expand Down Expand Up @@ -84461,47 +84461,33 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
<dl>
<dt><dfn data-x="navigation-status-id">id</dfn></dt>
<dd>The <span data-x="navigation-params-id">navigation id</span> for the navigation, or null if
the navigation is cancelled early or is a synchronous fragment navigation</dd>
the navigation is canceled early or is a synchronous fragment navigation</dd>

<dt><dfn data-x="navigation-status-status">status</dfn></dt>
<dd>A status code that is either
"<dfn data-x="navigation-status-cancelled"><code>cancelled</code></dfn>",
"<dfn data-x="navigation-status-canceled"><code>canceled</code></dfn>",
"<dfn data-x="navigation-status-pending"><code>pending</code></dfn>", or
"<dfn data-x="navigation-status-complete"><code>complete</code></dfn>".</dd>

<dt><dfn data-x="navigation-status-url">url</dfn></dt>
<dd>The URL which is being loaded in the navigation</dd>
</dl>

<p class="note">The navigation hooks have been designed with the WebDriver-BiDi
specification in mind. These may need to be adjusted for other use cases.
<ref spec="WEBDRIVERBIDI"></p>

<!-- NAVIGATE <dfn>navigate</dfn> -->
<!-- For places that _call_ this, as opposed to just referring to
it, search for "DONAV" -->
<p>To <dfn>navigate</dfn> a browsing context <var>browsingContext</var> to a resource
<p>To <dfn export>navigate</dfn> a browsing context <var>browsingContext</var> to a resource
<var>resource</var>, with an optional boolean <dfn id="exceptions-enabled"
export><var>exceptionsEnabled</var></dfn> (default false), an optional <span>history handling
behavior</span> <dfn data-x="navigation-hh"><var>historyHandling</var></dfn> (default "<code
data-x="hh-default">default</code>"), and an optional string <dfn
data-x="navigation-navigationtype"><var>navigationType</var></dfn> (default "<code
data-x="">other</code>"):</p>

<ol>
<li><p>Let <var>navigationStatus</var> be the result of <span>initiate navigate</span> with
<var>browsingContext</var>, <var>resource</var>, <var>exceptionsEnabled</var>,
<var>historyHandling</var>, and <var>navigationType</var>.</p></li>

<li><p>If <var>navigationStatus</var>'s <span data-x="navigation-status-status">status</span> is
"<code data-x="navigation-status-pending">pending</code>", run any <dfn>navigation started
steps</dfn> defined by <span>other applicable specifications</span> with
<var>navigationStatus</var>.</p></li>

<li><p>Return <var>navigationStatus</var>.</p></li>

</ol>

<p>To <dfn>initiate navigate</dfn> a browsing context <var>browsingContext</var> to a resource
<var>resource</var>, with boolean <var>exceptionsEnabled</var>, <span>history handling
behavior</span> <var>historyHandling</var>, and string <var>navigationType</var>:</p>

<ol>
<li><p>If <var>resource</var> is a <span>URL</span>, then set <var>resource</var> to a new <span
data-x="concept-request">request</span> whose <span data-x="concept-request-url">url</span> is
Expand Down Expand Up @@ -84539,7 +84525,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
is currently running the <span>unload a document</span> algorithm, then return a
new <span>navigation status</span> whose <span data-x="navigation-status-id">id</span> is null,
<span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-cancelled">cancelled</code>", and <span
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
data-x="concept-request-url">url</span> without affecting the preexisting attempt to navigate
<var>browsingContext</var>.</p></li>
Expand All @@ -84553,7 +84539,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
document</span> of <var>browsingContext</var>, then return a new <span>navigation status</span>
whose <span data-x="navigation-status-id">id</span> is null
and <span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-cancelled">cancelled</code>", without affecting the <span>prompt to
data-x="navigation-status-canceled">canceled</code>", without affecting the <span>prompt to
unload</span> algorithm.</p></li>
<!-- https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=1946 to 1955 -->

Expand Down Expand Up @@ -84601,7 +84587,10 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface

<li>
<p><span>Prompt to unload</span> the <span>active document</span> of <var>browsingContext</var>.
If the user <span>refused to allow the document to be unloaded</span>, then return.</p>
If the user <span>refused to allow the document to be unloaded</span>, then return a new
<span>navigation status</span> whose <span data-x="navigation-status-id">id</span> is null
and <span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>"</p>

<p>If this instance of the <span data-x="navigate">navigation</span> algorithm gets canceled
while this step is running, the <span>prompt to unload</span> algorithm must nonetheless be run
Expand Down Expand Up @@ -84631,20 +84620,27 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
data-x="bc-container">container</span>.</p></li>

<!-- Reusing the id for a reload means that if we're waiting for a navigation to complete and
it reloads/refreshes we get the event we expect when the final load completes -->
it reloads/refreshes we get the event we expect when the final navigation completes -->
<li><p>If <var>historyHandling</var> is "<code data-x="hh-reload">reload</code>",
and <var>browingContext</var>'s <span>active document</span>'s <span
data-x="concept-document-navigation-id">navigation id</span> is not null, let
<var>navigationId</var> be <var>browingContext</var>'s <span>active document</span>'s
<span data-x="concept-document-navigation-id">navigation id</span>. Otherwise let <var>navigation
id</var> be a new unique opaque string.</p>
id</var> be the string representation of a UUID based on truly random, or pseudo-random numbers
<ref spec=RFC4122></p>


<li><p>Return a new <span>navigation status</span>
<li><p>Let <var>navigationStatus</var> be a new <span>navigation status</span>
whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>,
<span data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
data-x="concept-request-url">url</span> and <span data-x="navigation-status-status">status</span>
is "<code data-x="navigation-status-pending">pending</code>", and continue running these steps
<span>in parallel</span>.</p></li>
is "<code data-x="navigation-status-pending">pending</code>".

<li><p>Run any <dfn>navigation started steps</dfn> defined by <span>other applicable
specifications</span> with <var>navigationStatus</var>.</p></li>

<li><p>Return <var>navigationStatus</var>, and continue running these steps
<span>in parallel</span></p>.</li>

<li>
<p>This is the step that attempts to obtain <var>resource</var>, if necessary. Jump to the first
Expand Down Expand Up @@ -85101,7 +85097,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
specifications</span> with a new <span>navigation status</span> whose
<span data-x="navigation-status-id">id</span> is <var>navigtionParams</var>'s
<span data-x="navigation-params-id">id</span>, <span data-x="navigation-status-status"
>status</span> is "<code data-x="navigation-status-cancelled">cancelled</code>", and <span
>status</span> is "<code data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>response</var>'s <span
data-x="concept-response-url">URL</span>.</p></li>

Expand Down Expand Up @@ -86923,8 +86919,8 @@ interface <dfn>BeforeUnloadEvent</dfn> : <span>Event</span> {
<span>other applicable specifications</span> with a new <span>navigation status</span> whose
whose <span data-x="navigation-status-id">id</span> is <var>document</var>'s <span
data-x="concept-document-navigation-id">navigation id</span>, <span
data-x="navigation-status-status">status</span> is "<code data-x="navigation-status-cancelled"
>cancelled</code>", and <span data-x="navigation-status-url">url</span> is
data-x="navigation-status-status">status</span> is "<code data-x="navigation-status-canceled"
>canceled</code>", and <span data-x="navigation-status-url">url</span> is
<var>document</var>'s <span data-x="concept-document-url">URL</span>.</p></li>
</ol>
</li>
Expand Down Expand Up @@ -111381,7 +111377,7 @@ document.body.appendChild(text);
data-x="serviceworkercontainer-service-worker-client">service worker client</span> is the
<code>Document</code> object's <span>relevant settings object</span>.</p></li>

<li><p>Call any <dfn>DOM load complete</dfn> steps defined in <span>other applicable
<li><p>Call any <dfn>DOM load complete steps</dfn> defined in <span>other applicable
specifications</span> with a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is the <code>Document</code> object's <span
data-x="concept-document-navigation-id">navigation id</span>, <span
Expand Down Expand Up @@ -111416,7 +111412,7 @@ document.body.appendChild(text);
the <code>Document</code> object's <span>relevant global object</span>, with <var>legacy target
override flag</var> set.</p></li>

<li><p>Call any <dfn>load complete</dfn> steps defined in <span>other applicable
<li><p>Call any <dfn>load complete steps</dfn>defined in <span>other applicable
specifications</span> with a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is the <code>Document</code> object's <span
data-x="concept-document-navigation-id">navigation id</span>, <span
Expand Down Expand Up @@ -123006,6 +123002,9 @@ INSERT INTERFACES HERE
<dt id="refsRFC3864">[RFC3864]</dt>
<dd><cite><a href="https://tools.ietf.org/html/rfc3864">Registration Procedures for Message Header Fields</a></cite>, G. Klyne, M. Nottingham, J. Mogul. IETF.</dd>

<dt id="refsRFC4122">[RFC4122]</dt>
<dd><cite><a href="https://tools.ietf.org/html/rfc4122">A Universally Unique IDentifier (UUID) URN Namespace</a></cite>, P. Leach, M. Mealling, R. Salz. IETF</dd>

<dt id="refsRFC4329">[RFC4329]</dt>
<dd>(Non-normative) <cite><a href="https://tools.ietf.org/html/rfc4329">Scripting Media Types</a></cite>, B. H&ouml;hrmann. IETF.</dd>

Expand Down Expand Up @@ -123131,6 +123130,9 @@ INSERT INTERFACES HERE
<dt id="refsWEBCRYPTO">[WEBCRYPTO]</dt>
<dd>(Non-normative) <cite><a href="https://w3c.github.io/webcrypto/Overview.html">Web Cryptography API</a></cite>, M. Watson. W3C.</dd>

<dt id="refsWEBDRIVERBIDI">[WEBDRIVERBIDI]</dt>
<dd>(Non-normative) <cite><a href="https://w3c.github.io/webdriver-bidi/">WebDriver BiDi</a></cite>. W3C</dd>

<dt id="refsWEBGL">[WEBGL]</dt>
<dd><cite><a href="https://www.khronos.org/registry/webgl/specs/latest/">WebGL Specifications</a></cite>, D. Jackson, J. Gilbert. Khronos Group.</dd>

Expand Down

0 comments on commit 5be33e8

Please sign in to comment.