Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits with link rel=expect #10180

Closed
jakearchibald opened this issue Mar 6, 2024 · 4 comments · Fixed by #10184
Closed

Nits with link rel=expect #10180

jakearchibald opened this issue Mar 6, 2024 · 4 comments · Fixed by #10184
Assignees
Labels
clarification Standard could be clearer topic: rendering

Comments

@jakearchibald
Copy link
Collaborator

What is the issue with the HTML Standard?

https://html.spec.whatwg.org/multipage/links.html#link-type-expect

the link might block rendering until that element's closing tag is parsed.

That seems like a pretty rough approximation of the behaviour. Should this be in a non-normative section? I found it misleading initially (eg "what if the element isn't inserted by the parser?")

Whenever the following conditions occur for a link element el:

Feels like this should be "any of the following". It isn't clear it's an "any" situation until the "or" at the end of the penultimate condition.

@keithamus keithamus added clarification Standard could be clearer topic: rendering labels Mar 6, 2024
@noamr noamr self-assigned this Mar 6, 2024
@noamr
Copy link
Contributor

noamr commented Mar 6, 2024

What is the issue with the HTML Standard?

https://html.spec.whatwg.org/multipage/links.html#link-type-expect

the link might block rendering until that element's closing tag is parsed.

That seems like a pretty rough approximation of the behaviour. Should this be in a non-normative section? I found it misleading initially (eg "what if the element isn't inserted by the parser?")

Yea, I was cargo-culting the rest of the links, e.g. https://html.spec.whatwg.org/multipage/links.html#link-type-opener. Those "The keyword indicates" sentences are not exactly normative. I'm OK with doing whatever with this.

Whenever the following conditions occur for a link element el:

Feels like this should be "any of the following". It isn't clear it's an "any" situation until the "or" at the end of the penultimate condition.

ack

@jakearchibald
Copy link
Collaborator Author

Eh, maybe get a second opinion on whether it's better to copy the other links or not.

@domenic
Copy link
Member

domenic commented Mar 7, 2024

I agree that we should probably reword the introductory text to be a bit more accurate. It's not normative, but it should probably avoid being confusing. I don't have any immediate suggestions for how to summarize the behavior while staying concise, though.

@noamr
Copy link
Contributor

noamr commented Mar 7, 2024

Gave it a try at #10184

domenic pushed a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: rendering
Development

Successfully merging a pull request may close this issue.

4 participants