Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLHyperlinkElementUtils' password getter steps are out of sync with the URL spec #2240

Closed
TRowbotham opened this issue Jan 4, 2017 · 1 comment
Closed

HTMLHyperlinkElementUtils' password getter steps are out of sync with the URL spec #2240

TRowbotham opened this issue Jan 4, 2017 · 1 comment

Comments

@TRowbotham
Copy link
Contributor

whatwg/url#186 made it so that passwords can no longer be null. In the HTML spec for the HTMLHyperlinkElementUtils interface, step number 3 of the password attribute's getter states:

  1. If url or url's password is null, return the empty string.

This should probably be rephrased to the following, to be less misleading about the values that a url's password can contain:

  1. If url is null, return the empty string.
@annevk
Copy link
Member

annevk commented Jan 5, 2017 •
edited
Loading

Thank you, I did not realize we kept username/password getters for these. I can create a fix.

annevk added a commit that referenced this issue Jan 5, 2017
@annevk
Align <a>/<area>.password with the URL Standard
e89f540 
See whatwg/url@5e0b05e for the change to the URL Standard.

Tests (the same as those created for the URL Standard are applicable here): web-platform-tests/wpt#4405.

Fixes: #2240.
@annevk annevk mentioned this issue Jan 5, 2017
Merged
domenic pushed a commit that referenced this issue Jan 5, 2017
@annevk @domenic
Align <a>/<area>.password with the URL Standard
165aeec 
See whatwg/url@5e0b05e for the change to the URL Standard.

Fixes #2240.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@annevk
Align <a>/<area>.password with the URL Standard
a50f902 
See whatwg/url@5e0b05e for the change to the URL Standard.

Fixes whatwg#2240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annevk @TRowbotham