Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for null passwords #186

Merged
merged 3 commits into from
Jan 3, 2017
Merged

No need for null passwords #186

merged 3 commits into from
Jan 3, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 28, 2016

It turns out that preserving the ability to serialize an empty string
password is not something any implementation supports.

Fixes #181.

It turns out that preserving the ability to serialize an empty string
password is not something any implementation supports.

Fixes #181.
@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label Dec 28, 2016
@domenic
Copy link
Member

domenic commented Dec 28, 2016

To be fair, I haven't tested Safari TP yet, and they went to a lot of trouble to become spec-compliant, so we should check that first... I'm heading into work (and thus to my testing Mac) so I should be able to get back to you soon.

@annevk
Copy link
Member Author

annevk commented Dec 28, 2016

Safari TP normalizes it away. I checked.

@annevk
Copy link
Member Author

annevk commented Dec 29, 2016

The difference between Firefox and others is with https://test:@test/. Then : does not disappear. I'll file a bug on that.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Dec 29, 2016
@annevk
Copy link
Member Author

annevk commented Dec 29, 2016

@annevk annevk removed the needs tests Moving the issue forward requires someone to write tests label Dec 29, 2016
<p>If <var>url</var>'s <a for=url>username</a> is not the empty string
or <var>url</var>'s <a for=url>password</a> is non-null, run these substeps:
<p>If <var>url</var>'s <a for=url>username</a> or <a for=url>password</a> is not
the empty string, then:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably use the "includes credentials" concept?

domenic added a commit to jsdom/whatwg-url that referenced this pull request Dec 29, 2016
annevk added a commit to web-platform-tests/wpt that referenced this pull request Jan 3, 2017
@annevk annevk merged commit 5e0b05e into master Jan 3, 2017
@annevk annevk deleted the annevk/nullify-null-password branch January 3, 2017 17:31
domenic added a commit to jsdom/whatwg-url that referenced this pull request Jan 3, 2017
jasnell added a commit to jasnell/node that referenced this pull request Jan 4, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186.
Fixes: nodejs#10595
jasnell added a commit to nodejs/node that referenced this pull request Jan 6, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186
PR-URL: #10601
Fixes: #10595
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186
PR-URL: nodejs#10601
Fixes: nodejs#10595
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186
PR-URL: nodejs#10601
Fixes: nodejs#10595
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186
PR-URL: nodejs#10601
Fixes: nodejs#10595
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
Pulls in new URL parsing tests from w3c web-platform-tests and updates
null password handling.

Refs: web-platform-tests/wpt@e001240
Refs: whatwg/url#186
PR-URL: nodejs#10601
Fixes: nodejs#10595
Reviewed-By: Michal Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bors-servo pushed a commit to servo/rust-url that referenced this pull request Oct 31, 2017
Properly handle empty username or password

Imports test changes from:
web-platform-tests/wpt@e001240

Related URL spec changes: whatwg/url#186

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/406)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants