Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.event and .htmlFor on HTMLScriptElement should reflect the "event" and "for" attributes #253

Closed
ayg opened this issue Oct 13, 2015 · 2 comments
Closed

.event and .htmlFor on HTMLScriptElement should reflect the "event" and "for" attributes #253

ayg opened this issue Oct 13, 2015 · 2 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project normative change

Comments

@ayg
Copy link
Contributor

ayg commented Oct 13, 2015

We seem to have perfect interop here, so the spec is wrong. I would write the spec/test patches myself, but I won't be able to for six months or so, so if anyone wants to before then, feel free. This test will need to be updated:

http://w3c-test.org/html/obsolete/requirements-for-implementations/other-elements-attributes-and-apis/script-IDL-event-htmlfor.html
@domenic domenic added normative change good first issue Ideal for someone new to a WHATWG standard or software project labels Oct 13, 2015
@zcorpan
Copy link
Member

zcorpan commented Oct 19, 2015

Some pointers in case a new contributor wants to take this:

https://html.spec.whatwg.org/multipage/obsolete.html#dom-script-event

New text should be

The event IDL attribute of the script element must reflect the element's event content attribute.

The htmlFor IDL attribute of the script element must reflect the element's for content attribute.

The test is in https://github.com/w3c/web-platform-tests/

@vakila
Copy link
Contributor

vakila commented Oct 26, 2015

I'd like to fix this if no one else is working on it. I couldn't find a corresponding issue in w3c/web-platform-tests, so I'll open one.

@vakila vakila mentioned this issue Oct 26, 2015
Closed
vakila added a commit to vakila/html that referenced this issue Oct 26, 2015
@vakila
Make script element IDL attributes reflect content attributes
17a9b94 
Per whatwg#253, change the spec to make the .event and .htmlFor IDL attributes
of the HTMLScriptElement reflect the "event" and "for" content attributes.

The corresponding test must also be changed (see web-platform-tests/wpt#2280).
@vakila vakila mentioned this issue Oct 26, 2015
Closed
vakila added a commit to vakila/web-platform-tests that referenced this issue Oct 26, 2015
@vakila
Fix web-platform-tests#2280: Update HTMLScriptElement event and htmlF…
9edc9ec 
…or tests

Update the tests for the event and htmlFor IDL attributes of the
HTMLScriptElement to expect the correct behavior:

The .event and .htmlFor IDL attributes of the script element should reflect
the element's "event" and "for" content attributes (respectively),
and not return the empty string on getting and do nothing on setting
as previously stated.

See whatwg/html#253 for the related correction to the spec.
@vakila vakila mentioned this issue Oct 26, 2015
Merged
vakila added a commit to vakila/html that referenced this issue Oct 27, 2015
@vakila
Fixes whatwg#253: Make script element IDL attributes reflect content …
5f72589 
…attributes

Per whatwg#253, change the spec to make the .event and .htmlFor IDL attributes
of the HTMLScriptElement reflect the "event" and "for" content attributes.

The corresponding test must also be changed (see web-platform-tests/wpt#2280).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project normative change
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zcorpan @domenic @ayg @vakila