Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 2 of Resource Fetch Algorithm for media elements is backwards #316

Closed
jdm opened this issue Nov 7, 2015 · 1 comment
Closed

Step 2 of Resource Fetch Algorithm for media elements is backwards #316

jdm opened this issue Nov 7, 2015 · 1 comment
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@jdm
Copy link
Member

jdm commented Nov 7, 2015

Step 1 says the mode is remote if a URL was provided, so the mode is local if a media object provider is present instead. Step 2 says to use the URL if the mode is local, otherwise use the resource from the media provider object.
@annevk annevk added the good first issue Ideal for someone new to a WHATWG standard or software project label Nov 7, 2015
foolip added a commit that referenced this issue Nov 24, 2015
@foolip
Flip around the mode check in the resource fetch algorithm
466bbd4 
Fixes #316
@foolip foolip mentioned this issue Nov 24, 2015
Merged
@foolip
Copy link
Member

foolip commented Nov 24, 2015

Thanks @jdm! If you're by any chance implementing srcObject, perhaps you want to take a look at #295

foolip added a commit that referenced this issue Nov 25, 2015
@foolip @annevk
Fix #316: flip around the mode check in the resource fetch algorithm
2cdce89
foolip added a commit that referenced this issue Feb 1, 2016
@foolip
Add additiona ack for #316
6624c60 
Originally reported in
https://www.w3.org/Bugs/Public/show_bug.cgi?id=29066
foolip added a commit that referenced this issue Feb 1, 2016
@foolip
Add additional ack for #316
0b62bea 
Originally reported in
https://www.w3.org/Bugs/Public/show_bug.cgi?id=29066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @foolip @annevk