Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An un-activated Image Button submitter should add (0, 0) entries to the form data set #8785

Closed
jenseng opened this issue Jan 26, 2023 · 0 comments · Fixed by #8788
Closed

Comments

@jenseng
Copy link
Member

jenseng commented Jan 26, 2023

If a form data set is constructed with a non-activated Image Button submitter, implementations include entries for the default coordinate (0, 0). However, the spec prose seems to imply that entries should not be included in this case, i.e. ... before this algorithm was invoked the user indicated a coordinate. The only way for the user to indicate a coordinate is by activating the input.

This ambiguity is normally a non-issue in conventional form submissions, since typically the submitter would have been activated. However, this may pose a problem for scenarios like someForm.requestSubmit(someButtonThatWasNotClicked) and the new submitter parameter to FormData, if users expect browsers to skip non-activated Image Button submitters.

To bring the spec in line with all implementations, the form construction algorithm prose should probably be reworded to default the coordinate to (0, 0) if the user hasn't selected one, and the Image Button activation prose could be similarly simplified.

annevk added a commit that referenced this issue Jan 27, 2023
Tests: xhr/formdata/constructor-submitter.html.

Closes #8785.
annevk added a commit that referenced this issue Jan 28, 2023
Tests: xhr/formdata/constructor-submitter.html.

Closes #8785.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant