Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PopoverTargetElement mixin to PopoverInvokerElement #8979

Closed
nt1m opened this issue Mar 3, 2023 · 2 comments
Closed

Rename PopoverTargetElement mixin to PopoverInvokerElement #8979

nt1m opened this issue Mar 3, 2023 · 2 comments
Labels
clarification Standard could be clearer topic: popover The popover attribute and friends

Comments

@nt1m
Copy link
Member

nt1m commented Mar 3, 2023

This is mostly a nit, but I think it makes more sense, since the mixins apply to the invokers, not the popover targets.

@mfreed7 @josepharhar @annevk wdyt?
@annevk annevk added clarification Standard could be clearer topic: popover The popover attribute and friends labels Mar 3, 2023
@josepharhar
Copy link
Contributor

I agree! Let's change it

@josepharhar
Copy link
Contributor

Here is a patch to implement it in chrome: https://chromium-review.googlesource.com/c/chromium/src/+/4307849

@domenic domenic mentioned this issue Mar 8, 2023
Merged
4 tasks
@annevk annevk closed this as completed in dc27ce8 Mar 8, 2023
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 8, 2023
@josepharhar
Rename IDL mixin type name to PopoverInvokerElement
6b96ae3 
This was proposed here: whatwg/html#8979

Bug: 1307772
Change-Id: Id58b1cee9a3e170543f0d4f64d28b775a3f4c6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307849
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1114769}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer topic: popover The popover attribute and friends
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @nt1m @josepharhar