Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key event used for close requests #10043

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix key event used for close requests #10043

merged 1 commit into from
Mar 7, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 10, 2024

Esc keydown has always been what triggered close request behavior. This was just a mistake in writing the spec. You can verify interactively using https://boom-bath.glitch.me/dialog-events.html

/cc @lukewarlow @josepharhar

(See WHATWG Working Mode: Changes for more details.)


/interaction.html ( diff )

Esc keydown has always been what triggered close request behavior. This was just a mistake in writing the spec.
@domenic domenic added the topic: dialog The <dialog> element. label Jan 10, 2024
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@domenic
Copy link
Member Author

domenic commented Mar 4, 2024

Finally was able to dig into the tests issue here, and I found the problem. Tests will be exported from https://chromium-review.googlesource.com/c/chromium/src/+/5339289 soon.

@domenic domenic requested a review from annevk March 4, 2024 07:15
@domenic domenic added the topic: popover The popover attribute and friends label Mar 5, 2024
@annevk annevk merged commit d785cbe into main Mar 7, 2024
2 checks passed
@annevk annevk deleted the closewatcher-wrong-key branch March 7, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: close watchers topic: dialog The <dialog> element. topic: popover The popover attribute and friends
Development

Successfully merging this pull request may close these issues.

None yet

3 participants