Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccurate note about putImageData error #133

Merged
merged 1 commit into from Sep 11, 2015
Merged

Fix inaccurate note about putImageData error #133

merged 1 commit into from Sep 11, 2015

Conversation

domenic
Copy link
Member

@domenic domenic commented Sep 10, 2015

Per Web IDL, it will throw a TypeError, not a NotSupportedError. There
is no need to note such Web IDL-derived errors in the method
description.

This matches Blink, Gecko, and WebKit, but not Edge.

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=28327.

@Ms2ger
Copy link
Member

Ms2ger commented Sep 11, 2015

Already tested in 2dcontext/pixel-manipulation/2d.imageData.put.nonfinite.html since web-platform-tests/wpt@03e34ca.

Per Web IDL, it will throw a TypeError, not a NotSupportedError. There
is no need to note such Web IDL-derived errors in the method
description.

This matches Blink, Gecko, and WebKit, but not Edge.

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=28327.
@annevk annevk merged commit 30a1b4b into master Sep 11, 2015
@annevk annevk deleted the canvaserror branch September 11, 2015 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants