Define :enabled by reference to "actually disabled" #1672
Conversation
| <code>optgroup</code>, <code>option</code>, <code>menuitem</code>, or <code>fieldset</code> element | ||
| that is not <span data-x="concept-element-disabled">actually disabled</span>.</p> | ||
|
|
||
| <p class="note"><code>a</code> elements, <code>area</code> elements, and <code>link</code> elements |
There was a problem hiding this comment.
I think it's best to just remove this, instead of moving it to a note. I think it was probably from a time when a/area/link had disabled attributes.
There was a problem hiding this comment.
Fair enough. Should I omit the note entirely, or just revert 7df2ba0?
There was a problem hiding this comment.
Omitting entirely sounds best to me
|
Oh, sorry, I forgot, could you add yourself to the acknowledgments? Ready to merge otherwise. |
|
Good to go! |
|
Thanks! Great to have you contributing :) |
|
"This definition is used to determine what elements can be focused and which elements match the :disabled pseudo-class." should perhaps be updated as well? I wonder why this wasn't done from the start. There's no subtle difference? |
PR #1672 made :enabled use the actually disabled definition. This fixes the note below actually disabled to reflect that change.
|
I created a PR to update the note. |
PR #1672 made :enabled use the actually disabled definition. This fixes the note below actually disabled to reflect that change.
PR whatwg#1672 made :enabled use the actually disabled definition. This fixes the note below actually disabled to reflect that change.
It was not obvious that the list of conditions for
:enabledand:disabledare inverses of each other. This change preserves the repetition of element names, although even that could be pulled into a new "disableable element" concept.