Meta: simplify advice for pr/* branches #1847
Conversation
| (Omit the `+` sign; it’s just `diff` syntax to get the markdown viewer to highlight the line.) | ||
| If you change your mind later about globally enabling that behavior, you can disable it by removing those lines. | ||
|
|
||
| * Alternatively, to enable automatic fetch of branches in PRs from forks **just for this repo**, omit `--global` from the above command. |
There was a problem hiding this comment.
The above command does not contain --global?
There was a problem hiding this comment.
git config --global --add remote.origin.fetch "+refs/pull/*/head:refs/remotes/origin/pr/*" is the command, can you take a look at the rendered view and see if it's clear enough there?
There was a problem hiding this comment.
I see. How does that work though if it is in your .config file? There is nothing relating that to any repo.
There was a problem hiding this comment.
You have to run the command in the right repo and it'll update .git/config. I think if you run the command outside a repo it'll fail, so I think mentioning it would be unnecessarily wordy, but can do so if you think it'd help anyone.
There was a problem hiding this comment.
Oh okay. I guess I'll just defer to @sideshowbarker then. He should probably review this anyway since he added it.
|
LGTM, with "Meta:" instead of "Editorial:" I guess. Will let @sideshowbarker sign off. |
|
Oh, commit messages is where I'd seen "Meta:", I was looking for it when I filed #1849 |
Also fix the indentation.
foolip
force-pushed
the
simplify-pr-advice
branch
from
270329d
to
a14fc7d
Compare
foolip
changed the title
Also fix the indentation.