Remove some unimplemented menu and command features #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the command API properties commandType, commandLabel, commandIcon, commandHidden, commandDisabled, and commandChecked. It also removes document.commands. These were not implemented anywhere, and per #237, were not on track to be implemented. Without these APIs, the command facets Type, ID, Hint, Icon, and Checked State are no longer used by the specification. (The remaining facets, viz. Label, Access Key, Hidden State, Disabled State, and Action, are still used, mostly by the accesskey specification.)
The spec contains a provision wherein <menuitem>s can have command="" attributes which contain the ID of another command that they delegate to. This has not been implemented in either of the two engines which have implemented menu items. Part of #237.
domenic
force-pushed
the
remove-command-api
branch
from
db3a62b
to
d65089b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two separate commits, each with reasonably detailed commit descriptions. It's a start toward #237, but there are still things to do.