Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unimplemented menu and command features #244

Merged
merged 2 commits into from
Oct 14, 2015
Merged

Remove some unimplemented menu and command features #244

merged 2 commits into from
Oct 14, 2015

Commits on Oct 14, 2015

  1. Remove the command API and related concepts 

    This removes the command API properties commandType, commandLabel, commandIcon, commandHidden, commandDisabled, and commandChecked. It also removes document.commands. These were not implemented anywhere, and per #237, were not on track to be implemented.

Without these APIs, the command facets Type, ID, Hint, Icon, and Checked State are no longer used by the specification. (The remaining facets, viz. Label, Access Key, Hidden State, Disabled State, and Action, are still used, mostly by the accesskey specification.)
    @domenic
    domenic committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    389ec26 View commit details
    Browse the repository at this point in the history

  2. Remove the "master command" concept from menuitem 

    The spec contains a provision wherein <menuitem>s can have command="" attributes which contain the ID of another command that they delegate to. This has not been implemented in either of the two engines which have implemented menu items.

Part of #237.
    @domenic
    domenic committed Oct 14, 2015
    Configuration menu
    Copy the full SHA
    d65089b View commit details
    Browse the repository at this point in the history