Make self.name in workers [Replaceable] #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 22, 2017
domenic
added
the
compat
This is a follow-up to #2477, to address the compatibility problem discovered in https://bugzilla.mozilla.org/show_bug.cgi?id=1375457.
domenic
force-pushed
the
replaceable-worker-name
branch
from
28e3612
to
6f9dcc9
Compare
|
We're making both replaceable for consistency? |
|
Yeah, and it seems at least plausible people are running prettier.js in shared workers too? |
annevk
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2664, to
address the compatibility problem discovered in
https://bugzilla.mozilla.org/show_bug.cgi?id=1375457.
Tests: web-platform-tests/wpt#6319