Allow ".9" as the time in refresh <meta> #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2844. This also cleans up the algorithm to follow modern conventions aligned with Infra.
domenic
added
compat
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 20, 2017
Follows whatwg/html#2852, and also adds some extra coverage for other weird floating point numbers.
domenic
commented
Jul 20, 2017
|
|
||
| <li><p><span>Skip ASCII whitespace</span> within <var>input</var> given | ||
| <var>position</var>.</p></li> | ||
|
|
||
| <li><p>Let <var>time</var> be 0.</p></li> |
There was a problem hiding this comment.
This block (14312-14328) contains the normative changes.
annevk
approved these changes
Jul 21, 2017
|
@annevk I've added those tests to the tests PR. At least one browser passes all of them. |
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 21, 2017
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 31, 2017
Follows whatwg/html#2852, and also adds some extra coverage for other weird floating point numbers.
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 31, 2017
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Aug 4, 2017
…a '.' without a leading 0 https://bugs.webkit.org/show_bug.cgi?id=175132 Reviewed by Darin Adler. LayoutTests/imported/w3c: Re-sync WPT tests from upstream c8bf1bbe9296. This extends test coverage. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents-expected.txt: Removed. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document-expected.txt: Added. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/refresh.sub.html: Added. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/w3c-import.log: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/w3c-import.log: Source/WebCore: Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.', without a leading 0. This is as per whatwg/html#2852. The latest spec is at: - https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html * html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTTPRefreshInternal): LayoutTests: * TestExpectations: Mark as flaky tests that used to not run because they were missing a subresource. Now that I imported this subresource, the tests run but are failing. When they fail, those tests are flaky due to the lines they log. * tests-options.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@220252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ryanhaddad
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 22, 2020
…a '.' without a leading 0 https://bugs.webkit.org/show_bug.cgi?id=175132 Reviewed by Darin Adler. LayoutTests/imported/w3c: Re-sync WPT tests from upstream c8bf1bb. This extends test coverage. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-1-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents-expected.txt: Removed. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document-expected.txt: Added. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/remove-from-document.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/moving-documents.html. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/refresh.sub.html: Added. * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/support/w3c-import.log: * web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/w3c-import.log: Source/WebCore: Fix parsing of <meta http-equiv=refresh> to allow time starting with a '.', without a leading 0. This is as per whatwg/html#2852. The latest spec is at: - https://html.spec.whatwg.org/multipage/semantics.html#attr-meta-http-equiv-refresh Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html * html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTTPRefreshInternal): LayoutTests: * TestExpectations: Mark as flaky tests that used to not run because they were missing a subresource. Now that I imported this subresource, the tests run but are failing. When they fail, those tests are flaky due to the lines they log. * tests-options.json: Canonical link: https://commits.webkit.org/191915@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2844. This also cleans up the algorithm to follow modern
conventions aligned with Infra.
Tests: web-platform-tests/wpt#6595
@tkent-google, I will point to the specific lines that are new; the rest is cleanups. @annevk, would appreciate your careful review on the modernization. (I didn't go so far as to eliminate gotos, however.)