Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: decrease traversals for module graph fetching #2971

Merged
merged 4 commits into from
Sep 6, 2017

Commits on Aug 31, 2017

  1. Editorial: decrease traversals for module graph fetching

    Previously, we could invoke the internal module script graph fetching
    procedure once for each combination of node and ancestor list, i.e. once
    for each node and for each path to the node. This could be up to O(2^n)
    for n nodes, as seen in
    https://gist.github.com/domenic/d877f8b2e6d6ae62a9c94f916739e4db.
    
    This change simplifies the model by using a single visited set per
    top-level fetch, which ensures that the internal module script graph
    fetching procedure is only invoked once for each node.
    
    This change is technically editorial, as it has no visible, testable
    effects. But it makes it much easier for implementers to follow the
    specification as written without causing themselves massive slowdowns.
    domenic committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    7768872 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2017

  1. Merge steps per annevk

    domenic committed Sep 2, 2017
    Configuration menu
    Copy the full SHA
    4e37a02 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. Fixes per review

    domenic committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    61fbb05 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. Configuration menu
    Copy the full SHA
    efb17d6 View commit details
    Browse the repository at this point in the history