Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noopener from tokenizedFeatures #3297

Merged
merged 1 commit into from
May 3, 2019
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 16, 2017

Apparently CSSOM needs to react differently if it's there.

Helps with #1902.


/infrastructure.html ( diff )
/window-object.html ( diff )

@annevk
Copy link
Member Author

annevk commented Dec 18, 2017

So given #1902 (comment) I guess with this fix it would still be good to have tests and implementation bugs. Do you know if we have tests?

@zcorpan
Copy link
Member

zcorpan commented Dec 18, 2017

@annevk annevk added do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests integration interop Implementations are not interoperable with each other labels Feb 4, 2018
Otherwise CSSOM will assume it's more than a new window.

Helps with #1902.

Tests: ...
@annevk
Copy link
Member Author

annevk commented Apr 12, 2019

I've made this account for noreferrer as well now. And I landed some tests for BarProp stuff, but unfortunately those don't seem to do the trick in Chrome.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Apr 18, 2019
@annevk annevk removed do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests labels Apr 18, 2019
@annevk
Copy link
Member Author

annevk commented Apr 18, 2019

I think I'd be okay with landing this given that there's now some tests, even though they don't quite show the issue in Chrome yet (they will after a bug is fixed).

@bzbarsky what do you think, does this improve the status quo even if the CSSOM bits aren't done? Should there be another test that compares non-BarProp aspects of the windows, e.g., viewport width or height?

@bzbarsky
Copy link
Contributor

I think this does improve things even without the CSSOM bits.

Doing a test that compares innerWidth/innerHeight and outerWidth/outerHeight with the "known good" window does seem like a good idea.

@annevk
Copy link
Member Author

annevk commented May 3, 2019

@zcorpan or @domenic want to give this a final pass? Chrome and Firefox agree on this now.

@annevk annevk merged commit c0b75ea into master May 3, 2019
@annevk annevk deleted the annevk/remove-noopener branch May 3, 2019 09:40
annevk added a commit to web-platform-tests/wpt that referenced this pull request May 3, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 5, 2019
…opener/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: ensure BarProps are visible for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac
wpt-pr: 16330
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 5, 2019
…/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: compare window sizing for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ec1d6a114188765744910ed4dfc63fc1fa4ca2c6
wpt-pr: 16658
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jun 6, 2019
…opener/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: ensure BarProps are visible for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac
wpt-pr: 16330
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Jun 6, 2019
…/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: compare window sizing for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ec1d6a114188765744910ed4dfc63fc1fa4ca2c6
wpt-pr: 16658
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…opener/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: ensure BarProps are visible for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac
wpt-pr: 16330

UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…opener/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: ensure BarProps are visible for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac
wpt-pr: 16330

UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…opener/noreferrer, a=testonly

Automatic update from web-platform-tests
HTML: ensure BarProps are visible for noopener/noreferrer

For whatwg/html#3297.

--

wpt-commits: ce675f004d08b1dfd7f4bbf3dbb422229addedac
wpt-pr: 16330

UltraBlame original commit: 5e1ab479dde3882aa3d4661a4f3336df60d8dec8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration interop Implementations are not interoperable with each other
Development

Successfully merging this pull request may close these issues.

None yet

3 participants