Cleanup Path2D constructor #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts f635643 which added a constructor that did not get implemented. (Verified for Chrome, Firefox, and Safari by inspecting IDL.) It also changes the constructor signature slightly to more idiomatic IDL and makes various editorial improvements.
annevk
added
topic: canvas
needs tests
|
@whatwg/canvas should probably give an okay here as it changes the binding slightly (at least, I think making the argument optional will affect how "undefined" is handled, but with this change it'll be handled as developers expect). In addition, it removes a |
annevk
added
normative change
removal/deprecation
junov
approved these changes
Jan 26, 2018
|
TODO:
|
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts f635643 which added a constructor that did not get implemented. (Verified for Chrome, Firefox, and Safari by inspecting IDL.)
It also changes the constructor signature slightly to more idiomatic IDL and makes various editorial improvements.
/canvas.html ( diff )