Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call out inconsistency in document.body behavior #3449

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Call out inconsistency in document.body behavior #3449

merged 2 commits into from
Feb 12, 2018

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 5, 2018 •
edited by pr-preview bot
Loading

@annevk annevk requested a review from domenic February 5, 2018 15:15
domenic
domenic requested changes Feb 5, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really find this clarifying. Getters and setters always have different behavior, i.e. one gets, and one sets. I don't think "different behavior" is a good way of phrasing this.

An example might be particularly helpful to illustrate what is meant.

@zcorpan
Copy link
Member Author

zcorpan commented Feb 5, 2018

Um, yeah you are right. :)

An example would be an SVG doc, and setting document.body to a body (which appends it to the root), then getting document.body (returns null).

@domenic
Copy link
Member

domenic commented Feb 5, 2018

Ah, awesome, "the value returned by the getter is not always the one passed to the setter" would be a great way of phrasing it :)

@zcorpan
Copy link
Member Author

zcorpan commented Feb 12, 2018

@domenic OK, please take a look :)

domenic
domenic approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thanks for the update!

@domenic
Copy link
Member

domenic commented Feb 12, 2018

Oh, I guess we don't usually use "Editorial:" for clarifications per https://github.com/whatwg/meta/blob/master/COMMITTING.md#title-prefixes

@domenic domenic added the clarification Standard could be clearer label Feb 12, 2018
@zcorpan zcorpan merged commit aa2bec4 into master Feb 12, 2018
@zcorpan zcorpan deleted the zcorpan/clarify-document-body branch February 12, 2018 16:20
@zcorpan zcorpan changed the title Editorial: call out inconsistency in document.body behavior Call out inconsistency in document.body behavior Feb 12, 2018
@scottaohara scottaohara mentioned this pull request Jun 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
clarification Standard could be clearer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcorpan @domenic